SemanticJournal icon indicating copy to clipboard operation
SemanticJournal copied to clipboard

Should sanitize permalink before checking if it needs to be changed

Open darkhelmet opened this issue 15 years ago • 1 comments

In Article#set_permalink, it seems that you should do Article.sanitize_permalink(new_permalink) before the check, so you can use the sanitized version to do the comparison, instead of checking, then sanitizing.

Unless I'm missing something...

darkhelmet avatar Jan 18 '10 05:01 darkhelmet

You've got a point there. Although, set_permalink isn't called from anywhere (yet), so it's no biggy. Thanks though!

ricroberts avatar Jan 18 '10 20:01 ricroberts