SwinjectStoryboard icon indicating copy to clipboard operation
SwinjectStoryboard copied to clipboard

Published 20 hours ago • verified publisher icon Swinject

Fix carthage build

Open gilroykilroy opened this issue 5 years ago • 3 comments

Fix carthage build by checking in the generated Swift header file into the project. Perhaps some tweaking of search paths would solve the problem too but I could not figure that out.

gilroykilroy avatar Jan 26 '20 19:01 gilroykilroy

when will this pull request be merged?

Lex-Nagtegaal avatar Mar 11 '20 08:03 Lex-Nagtegaal

Thank you for making the PR😃 and sorry for taking too long to respond🙇‍♂️

I'm not sure we still see the issue when using Carthage.

  • carthage-build.sh made in PR #156 might help users of Carthage.
  • Support of xcframework might be alternative.
  • Not sure but we'll see possibility that Carthage itself fixed the issue.

yoichitgy avatar Jul 02 '21 19:07 yoichitgy

Yeah I don't think this is necessary. The included ./carthage-build.sh helps get around the build issue when not using xcframeworks, and we'll add xcframework support in the next major version.

mpdifran avatar Jul 04 '21 15:07 mpdifran