Typo in adb reverse command

Open Hamz-a opened this issue 5 years ago • 0 comments

Currently when sending an adb reverse command, an error occurs:

RuntimeError: ERROR: 'FAIL' 0016malformed forward spec

After digging into the code and the adb source code, it turns out that there's a small typo in the command:

https://github.com/Swind/pure-python-adb/blob/9644c6b6c845152096421ba88382afc0d69d36d7/ppadb/command/transport/init.py#L165

This should be: reverse:forward:{remote};{local}, note the last : which should be ;. See:

https://github.com/aosp-mirror/platform_system_core/blob/fc1cf90741e59d5615a7dcea1813f38bfa3a2eec/adb/SERVICES.TXT#L246

Dec 10 '20 23:12 Hamz-a