SwiftyJSON icon indicating copy to clipboard operation
SwiftyJSON copied to clipboard

v4.3.0 fails build with XCode 9.4.1 (swift 4.1)

Open leonid-s-usov opened this issue 5 years ago • 4 comments

What did you do?

updating to version 4.3 fails a build on XCode 9.4.1

Environment

  • SwiftyJSON: *4.3.0 *
  • Xcode Version: 9.4.1 (9F2000) (Open Xcode; In menubar: Xcode > About Xcode)
  • Swift Version: 4.1 (Default) (Open Xcode Preferences; Components > Toolchains. If none, use Xcode Default.)

Please also mention which package manager you used and its version. Delete the other package managers in this list:

  • Carthage: 0.33.0 (Use carthage version in Terminal)

leonid-s-usov avatar Apr 13 '19 21:04 leonid-s-usov

v4.3.0 required Swift 5 to compile.

wongzigii avatar Apr 15 '19 07:04 wongzigii

So if you are committing a backward incompatible change then it should be a different major version, like 5.0

leonid-s-usov avatar Apr 15 '19 07:04 leonid-s-usov

@leonid-s-usov This is not a backward incompatible change. We don't add/remove any APIs in this version. You can use Xcode 10.2 to compile Swift 5, Swift 4.2, or Swift 4. Or you can add a .swift-version file to specify the Swift version if you don;t want to migrate to Swift 5.0 yet and CocoaPods will do all job for you when you running pod update

wongzigii avatar Apr 15 '19 11:04 wongzigii

It is backward incompatible in terms that in my Cartfile I used to have

SwiftyJSON ~> 4.0

and after carthage update, the project fails to build. I have an example of another project which somehow manages to maintain Carthage support of different XCodes

leonid-s-usov avatar Apr 15 '19 11:04 leonid-s-usov