Swiftify icon indicating copy to clipboard operation
Swiftify copied to clipboard

Don't rename "id" and similar variables

Open arlomedia opened this issue 4 years ago • 1 comments

Even though it's also a type name and confuses the code coloring in Xcode, "id" is a valid variable name in Objective-C and I've used it quite a bit. This should be even less of a problem in Swift because it's not a type name, but Swiftify renames my "id" variables to "anId":

input: NSString *id = @"foo"; output: let anId = "foo" expected: let id = "foo" demo: http://swiftify.me/i8a32t

Similarly:

input: for (NSString *id in sortedEvents) {} output: for anId in sortedEvents {} expected: for id in sortedEvents {}

I noticed the same behavior with variables named "url" being changed to "anUrl." I think in both languages, "URL" is a type, but "url" is a valid variable name.

arlomedia avatar Feb 23 '21 04:02 arlomedia

@arlomedia This makes perfect sense, will be fixed for sure.

alex-swiftify avatar Mar 03 '21 14:03 alex-swiftify