swiftweekly.github.io icon indicating copy to clipboard operation
swiftweekly.github.io copied to clipboard

Use `jekyll-mentions` for linking GitHub profiles for commits & PRs section

Open jessesquires opened this issue 7 years ago • 5 comments

https://github.com/jekyll/jekyll-mentions

currently we (sometimes) do this manually. this should allow us to just type @username and have it automatically "linkified".

we'll probably need to audit old issues to use this once implemented.

jessesquires avatar Sep 24 '17 18:09 jessesquires

Nice! I can do the audit. :)

BasThomas avatar Sep 25 '17 00:09 BasThomas

🎉 Thanks @BasThomas !

Just need to add it here to enable it https://github.com/SwiftWeekly/swiftweekly.github.io/blob/master/_config.yml#L6

jessesquires avatar Sep 25 '17 17:09 jessesquires

Also, turns out we can remove this from the gemfile: https://github.com/SwiftWeekly/swiftweekly.github.io/blob/master/Gemfile#L4

(it's included in github-pages)

jessesquires avatar Sep 25 '17 17:09 jessesquires

Am I correct in concluding that the suggested feature in this ticket has been implemented back in 2018?

jeroenleenarts avatar Mar 27 '21 22:03 jeroenleenarts

No, nothing implemented.

The discussion above was just about including the dependency.

jessesquires avatar Mar 28 '21 00:03 jessesquires