SwiftMessages icon indicating copy to clipboard operation
SwiftMessages copied to clipboard

Haptic Feedback

Open AbelToy opened this issue 5 years ago • 6 comments

Maybe it would be a good idea to add some optional haptic feedback to certain alerts.

According to the human guidelines, there's three levels of feedback for notifications: success, warning and error.

At the moment it can be added using event listeners, but adding default support for it on specific configurations would be helpful

AbelToy avatar Aug 10 '18 21:08 AbelToy

Will take care of this 👌👌

AlbertoSamele avatar Sep 20 '21 09:09 AlbertoSamele

Hello. Any chance to get this PR merged?

mikestalker avatar Jan 17 '22 12:01 mikestalker

@mikestalker it's been a long time since I made the PR so the branch eventually diverged, I will fix the conflicts this weekend so if it doesn't get merged and you really need my changes, you can just use my fork instead

AlbertoSamele avatar Jan 17 '22 13:01 AlbertoSamele

Thx @AlbertoSamele. Just switched from NotificationBannerSwift to SwiftMessages and wanted get this haptic effect as it was in old library here as well. Not critical but nice to have for consistency.

mikestalker avatar Jan 17 '22 13:01 mikestalker

Conflicts solved, my branch is now up to stream if you still want to use it @mikestalker

AlbertoSamele avatar Jan 19 '22 22:01 AlbertoSamele

Thank you @AlbertoSamele . Hopefully your PR will be merged and released soon. Any chanse for that @wtmoose ?

mikestalker avatar Jan 20 '22 09:01 mikestalker

@wtmoose can you please merge imrovements from @AlbertoSamele please?

mikestalker avatar Oct 31 '22 13:10 mikestalker

@wtmoose any chanse to get haptic feedback PR merged?

mikestalker avatar Jan 23 '24 09:01 mikestalker

Yeah. There were some problematic areas of the PR that prevented me from merging it. I went ahead and made the required updates. You can try it on the head of master

wtmoose avatar Jan 23 '24 18:01 wtmoose

Thanks @AlbertoSamele , thanks @wtmoose Works like a charm. Waiting for release.

mikestalker avatar Jan 24 '24 10:01 mikestalker