Arpad Borsos

Results 349 comments of Arpad Borsos

> I’m tempted to just copy-paste the whole `std::thread::scope` code and move it into a crate that reuses threads across invocations. I was playing around with that a little, but...

CI failures seem related to more aggressive dead code analysis and updated lints in newer compiler versions. I opened https://github.com/getsentry/sentry-cli/pull/2096 to unblock me here quickly.

The logic is indeed very complex and there is way too many moving parts, but we should always prefer the most recently uploaded bundle that contains the file being requested....

Hi there! I have published a bunch of "copy-pastable GHA workflows" for Rust here: https://github.com/Swatinem/rust-gha-workflows The [`complete-ci`](https://github.com/Swatinem/rust-gha-workflows/blob/e62fb0323b2e571f7fd85888f567a8f81bf997b6/.github/workflows/complete-ci.yml#L45-L75) workflow adds code coverage instrumentation based on `cargo-llvm-cov`, which I highly recommend over...

Yes, the stacktrace rules have an effect there. There is also `in_app` normalization, which defaults a `None` value to true/false depending on presence of either flag anywhere else in the...

You are absolutely right, the Sentry tracing/span types / APIs are unfortunately not tuned to be very high performant. I very much appreciate contributions to make them more so. This...

Conceptually, a Sentry `Scope` is not tied to tracing spans (or Sentry `Span`s for that matter) at all. As you mention `Future`s and their lifecycle, you must use the `SentryFuture`...

Also discussed with @elramen recently that IMO we shouldn’t bloat the SDK with types and definitions that are not directly useful for the SDK itself.

The crate is also implementing `binary_search` manually, as well as its own version of `IndexMap`. There is also unsafe code related to `SourceView`, which is a type that definitely has...

I’m also a bit unsure about making all the fields public. The crate already has a distinction between a raw JSON sourcemap, vs a more concrete type that you can...