crashes reported on playstore

[Swati4star]

1

java.lang.RuntimeException: 
  at android.os.AsyncTask$4.done (AsyncTask.java:399)
  at java.util.concurrent.FutureTask.finishCompletion (FutureTask.java:383)
  at java.util.concurrent.FutureTask.setException (FutureTask.java:252)
  at java.util.concurrent.FutureTask.run (FutureTask.java:271)
  at android.os.AsyncTask$SerialExecutor$1.run (AsyncTask.java:289)
  at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1167)
  at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:641)
  at java.lang.Thread.run (Thread.java:919)
Caused by: java.lang.IllegalStateException: 
  at android.graphics.pdf.PdfRenderer.nativeOpenPageAndGetSize (Native Method)
  at android.graphics.pdf.PdfRenderer.access$300 (PdfRenderer.java:105)
  at android.graphics.pdf.PdfRenderer$Page.<init> (PdfRenderer.java:312)
  at android.graphics.pdf.PdfRenderer$Page.<init> (PdfRenderer.java:289)
  at android.graphics.pdf.PdfRenderer.openPage (PdfRenderer.java:230)
  at swati4star.createpdf.util.PdfToImages.doInBackground (PdfToImages.java:78)
  at swati4star.createpdf.util.PdfToImages.doInBackground (PdfToImages.java:23)
  at android.os.AsyncTask$3.call (AsyncTask.java:378)
  at java.util.concurrent.FutureTask.run (FutureTask.java:266)

2

java.lang.NumberFormatException: 
  at java.lang.Integer.parseInt (Integer.java:618)
  at java.lang.Integer.parseInt (Integer.java:650)
  at swati4star.createpdf.fragment.ImageToPdfFragment.lambda$addMargins$11$ImageToPdfFragment (ImageToPdfFragment.java:850)
  at swati4star.createpdf.fragment.-$$Lambda$ImageToPdfFragment$3ePVrJyFjtIu8xVVs5HMraGVVVg.onClick (Unknown Source:2)
  at com.afollestad.materialdialogs.MaterialDialog.onClick (MaterialDialog.java:410)
  at android.view.View.performClick (View.java:6733)
  at android.view.View.performClickInternal (View.java:6691)
  at android.view.View.access$3400 (View.java:802)
  at android.view.View$PerformClick.run (View.java:26499)
  at android.os.Handler.handleCallback (Handler.java:873)
  at android.os.Handler.dispatchMessage (Handler.java:99)
  at android.os.Looper.loop (Looper.java:226)
  at android.app.ActivityThread.main (ActivityThread.java:7191)
  at java.lang.reflect.Method.invoke (Native Method)
  at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:499)
  at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:942)
  at .CPU

java.lang.NullPointerException: 
  at android.preference.PreferenceManager.getDefaultSharedPreferencesName (PreferenceManager.java:537)
  at android.preference.PreferenceManager.getDefaultSharedPreferences (PreferenceManager.java:526)
  at swati4star.createpdf.preferences.TextToPdfPreferences.<init> (TextToPdfPreferences.java:24)
  at swati4star.createpdf.model.TextToPDFOptions$Builder.<init> (TextToPDFOptions.java:56)
  at swati4star.createpdf.fragment.texttopdf.TextToPdfFragment.onPDFCreated (TextToPdfFragment.java:282)
  at swati4star.createpdf.util.TextToPdfAsync.onPostExecute (TextToPdfAsync.java:53)
  at android.os.AsyncTask.finish (AsyncTask.java:695)
  at android.os.AsyncTask.access$600 (AsyncTask.java:180)
  at android.os.AsyncTask$InternalHandler.handleMessage (AsyncTask.java:712)
  at android.os.Handler.dispatchMessage (Handler.java:106)
  at android.os.Looper.loop (Looper.java:193)
  at android.app.ActivityThread.main (ActivityThread.java:6912)
  at java.lang.reflect.Method.invoke (Native Method)
  at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:493)
  at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:860)

[rajeevrajeshuni]

@Swati4star I would like to take these up.

[Swati4star]

@rajeevrajeshuni sure

[rajeevrajeshuni]

Is there any more information about how to reproduce these crashes?

[anirudh8860]

Issue 1 is reproduced because a signed PDF has been tried to be updates

[avinashpatnaik]

@Swati4star I looked at issue number 2. Looks like there is a good possibility of leakage of context in TextToPdfFragment. I noticed getContext() is being used to get the context for TextToPDFOptions.Builder(getContext()).

There is a possibility getContext() may return null if the fragment is not attached to the activity. Since we already have mActivity as context coming as part of onAttach, we can use that.

I raised a PR. Please review and let me know what you think?

[traitsisgiorgos]

hi, is the issue still open?