Images-to-PDF icon indicating copy to clipboard operation
Images-to-PDF copied to clipboard

Published 20 hours ago • verified publisher icon Swati4star

Added drive-cloud support

Open jddeep opened this issue 5 years ago • 18 comments

Description

Added drive-cloud support IMG-20190323-WA0004 IMG-20190323-WA0002 IMG-20190323-WA0001 IMG-20190323-WA0003

Fixes #164

Type of change

Just put an x in the [] which are valid.

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

  • [x] ./gradlew assembleDebug assembleRelease
  • [x] ./gradlew checkstyle

Checklist:

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings

jddeep avatar Mar 23 '19 11:03 jddeep

Code Climate has analyzed commit 2a2abb9b and detected 0 issues on this pull request.

View more on Code Climate.

codeclimate[bot] avatar Mar 23 '19 11:03 codeclimate[bot]

@Swati4star @vyankatesh24 Please review.

jddeep avatar Mar 23 '19 12:03 jddeep

@jddeep All checks have failed, look over it.

vyankatesh24 avatar Mar 23 '19 17:03 vyankatesh24

@Swati4star @vyankatesh24 Please review now. Thanks.

jddeep avatar Mar 24 '19 01:03 jddeep

@jddeep I'm getting Choose acc window but, after choosing account nothing is happening.

vyankatesh24 avatar Mar 24 '19 05:03 vyankatesh24

@vyankatesh24 you need to wait for few time to handlesignin . Click the button again once.

jddeep avatar Mar 24 '19 05:03 jddeep

@vyankatesh24 you need to wait for few time to handlesignin . Click the button again once.

I've tried multiple times

vyankatesh24 avatar Mar 24 '19 05:03 vyankatesh24

@vyankatesh24 That doesn't make sense. I have tested it on couple of devices and it works fine every where. Do you have internet connection on your device?

jddeep avatar Mar 24 '19 06:03 jddeep

@Swati4star Please review,

jddeep avatar Mar 24 '19 06:03 jddeep

Please make sure that the device it is being tested on has active internet connection.

jddeep avatar Mar 24 '19 06:03 jddeep

@sidhuparas @srv-twry please review this PR. and do run it locally on your devices.

Swati4star avatar Mar 24 '19 15:03 Swati4star

Yeah, will do it by afternoon.

dr0pdb avatar Mar 25 '19 01:03 dr0pdb

@jddeep Nothing is happening after selecting my google profile. I do have a good internet connection.

dr0pdb avatar Mar 25 '19 10:03 dr0pdb

@srv-twry have you tried clicking the button again?

jddeep avatar Mar 25 '19 10:03 jddeep

@srv-twry Please check. Everything runs fine on my side.

jddeep avatar Mar 25 '19 11:03 jddeep

@srv-twry the issue is with the App ID. You need to provide one of yours as your SSH key doesn't match with the current one(mine).

jddeep avatar Mar 25 '19 16:03 jddeep

@jddeep So you mean I have to create a new project in the console and then use that?

have you tried clicking the button again?

Yes, I have tried clicking on it multiple times. It doesn't work

dr0pdb avatar Mar 26 '19 03:03 dr0pdb

@jddeep I'll take this PR further. I'll create new keys for the drive & integrate it later. Thanks fo thi implementation! I am keeping this PR open. (and adding your points for this)

You can work on other issues now 👍

Swati4star avatar Mar 27 '19 11:03 Swati4star