Images-to-PDF icon indicating copy to clipboard operation
Images-to-PDF copied to clipboard

Implement Proper "View Images in Gallery" Button Functionality

Open SamithaKosanam opened this issue 1 year ago • 1 comments

Description

After extracting image(s) from a PDF, the "View Images in Gallery" button would fail to actually show the extracted images in the Gallery. This change makes this button functional by putting the correct image content in the URI, which was done by building on a previous pull request that made acceptable changes to the ImageUtils.java file, but this change also adds changes to the FileUtils.java file, as well as the PdfToImageFragment.java file.

Fixes #1058

Type of change

Just put an x in the [] which are valid.

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

  • [x] ./gradlew assembleDebug assembleRelease
  • [x] ./gradlew checkstyle

Checklist:

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings

SamithaKosanam avatar Oct 03 '22 22:10 SamithaKosanam

Code Climate has analyzed commit 8bf09a82 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

View more on Code Climate.

codeclimate[bot] avatar Oct 03 '22 22:10 codeclimate[bot]