Images-to-PDF icon indicating copy to clipboard operation
Images-to-PDF copied to clipboard

fix bugs induced by android:drawableTint

Open rudmannn opened this issue 1 year ago • 1 comments

Description

I found that you use the attribute android:drawableTint in the file fragment_about_us.xml. Such an attribute can induce incompatibilities at API level below 23.

API level 32 2b19381ed0cb5ca6f2e0b269a5e7eae

API level 22 and 23 5dc781cf9e3e161d355a692088132b1

This pull request changes android:drawableTint to app:drawableTint so that the icons look the same among API levels.

Type of change

Just put an x in the [] which are valid.

  • [ x ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  1. Open the app
  2. Click "Option" button
  3. Choose "About Us"
  4. Notice the orange icon colors at API level 22 and 23

Checklist:

  • [ x] My code follows the style guidelines of this project
  • [ x] I have performed a self-review of my own code
  • [ x] I have commented my code, particularly in hard-to-understand areas
  • [ x] I have made corresponding changes to the documentation
  • [ x] My changes generate no new warnings

rudmannn avatar Jul 19 '22 06:07 rudmannn

Code Climate has analyzed commit ddcf4023 and detected 0 issues on this pull request.

View more on Code Climate.

codeclimate[bot] avatar Jul 19 '22 06:07 codeclimate[bot]