Images-to-PDF icon indicating copy to clipboard operation
Images-to-PDF copied to clipboard

Fix 1053: Storage location not created and setting not honored

Open KOISHI-CHEN opened this issue 2 years ago • 1 comments

Description

Please include a summary of the change and which issue is fixed. List any dependencies that are required for this change. If there are any UI change, please include the screenshots also.

  • let defaultstorage path will be created with the mainActivity start
  • create a unified entrance to get the default path
  • let user can modify the storage path (use the original code,I why don't why it is commented out). I test it on api 26 and api 30 ,it works well.

Fixes #1053

Type of change

Just put an x in the [] which are valid.

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

  • [ ] ./gradlew assembleDebug assembleRelease
  • [x] ./gradlew checkstyle

Checklist:

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings

KOISHI-CHEN avatar May 21 '22 13:05 KOISHI-CHEN

Code Climate has analyzed commit f76ad98d and detected 0 issues on this pull request.

View more on Code Climate.

codeclimate[bot] avatar May 21 '22 13:05 codeclimate[bot]