Images-to-PDF icon indicating copy to clipboard operation
Images-to-PDF copied to clipboard

#1071 fix use camera and general permission request

Open wzy1935 opened this issue 2 years ago • 1 comments

Description

Changed files: Constants.java, ImageToPdfFragment.java, MainActivity.java, PermissionsUtils.java

  • Changing permission requirement. Now users using the "Image to pdf" function will also require camera permission.
  • Fix cancel permission feedback. Now when the user rejects to provide permissions, the popup window will show.

Fixes #1071

Type of change

Just put an x in the [] which are valid.

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

  • [x] ./gradlew assembleDebug assembleRelease
  • [x] ./gradlew checkstyle

Checklist:

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings

wzy1935 avatar May 21 '22 12:05 wzy1935

Code Climate has analyzed commit db58ebe6 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

View more on Code Climate.

codeclimate[bot] avatar May 21 '22 12:05 codeclimate[bot]