Images-to-PDF icon indicating copy to clipboard operation
Images-to-PDF copied to clipboard

Feature Request: Resize page to fit image

Open ghost opened this issue 3 years ago • 10 comments

Describe your issue here.

Steps to reproduce

Image to PDF When image is not A4 size or other fixed aspect ratio, white borders appear even when border size is set to 0.

Expected behaviour

Border must have zero size and page must resize to fit image.

"Set Page Size" must have "Resizable to fit image" option.

Actual behaviour

White borders appear.

Would you like to work on the issue?

Tell us if you would like to work on this issue

ghost avatar Jan 23 '22 12:01 ghost

@5lttrz Please add some screenshots for a better understanding of your issue.

codegsaini avatar Jan 31 '22 17:01 codegsaini

When image is cropped in editor

Screenshot_20220201-080308_PDF Converter.png

White borders appear

Screenshot_20220201-080437_MiXplorer.png

Even though border size has been set to 0. This can be fixed by having resizable page size. (Default is A4)

Suggestion: In Page Size options, add a "resizable" option which makes the page itself resize, rather than adding white border to pad it into A4 or other aspect ratio selected.

iAmAGitUser5 avatar Feb 01 '22 02:02 iAmAGitUser5

@Swati4star @5lttrz Shall I work on this issue?

Pragya001 avatar Mar 10 '22 17:03 Pragya001

I guess yea, I'm not a contributor though, codegsaini is.

iAmAGitUser5 avatar Mar 10 '22 17:03 iAmAGitUser5

@Pragya001 You can work on it.

codegsaini avatar Mar 12 '22 09:03 codegsaini

@Pragya001 @codegsaini https://github.com/Swati4star/Images-to-PDF/pull/1052 ✨

valeryvpetrov-dev avatar Mar 27 '22 12:03 valeryvpetrov-dev

@valeryvpetrov-dev is that what you already worked on?

Pragya001 avatar Mar 28 '22 07:03 Pragya001

@Pragya001 no. I've seen issue and decided to help.

valeryvpetrov-dev avatar Mar 29 '22 06:03 valeryvpetrov-dev

Hi, I am Josie, and I am very interested in this issue. May I have this issue assigned to me?

u7505884 avatar Oct 15 '23 10:10 u7505884

@u7505884 I think this issue is solved via PR #1052. Please refer to the PR.

codegsaini avatar Oct 21 '23 18:10 codegsaini