swapr-dapp icon indicating copy to clipboard operation
swapr-dapp copied to clipboard

Removed trades sorting and trade types functions from App and moved it to sdk

Open Mi-Lan opened this issue 2 years ago โ€ข 3 comments

This pr is linked to sdk pr https://github.com/levelkdev/swapr-sdk/pull/221

  • So I moved all the logic related to eco router trades from dapp to the sdk so that it fetches and sorts trades all on the sdk side and on the front-end we just take those trades and display them.
  • It is reduced to one function which you get from sdk which takes in these parameters Screenshot 2022-11-28 at 19 06 33

Mi-Lan avatar Nov 28 '22 18:11 Mi-Lan

Deploy Preview for swapr ready!

Name Link
Latest commit a10bcfa31fb7baf41483a7a5687d8fe78a659dc9
Latest deploy log https://app.netlify.com/sites/swapr/deploys/6384f7d39fab230008de9037
Deploy Preview https://deploy-preview-1601--swapr.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Nov 28 '22 18:11 netlify[bot]

Tested and noticed difference was in the values โ€‹โ€‹of min. received between the results on the eco router results and the official dex website...

image

Sushiswap image

Uniswap image

MilanVojnovic95 avatar Nov 29 '22 15:11 MilanVojnovic95

Tested and noticed difference was in the values โ€‹โ€‹of min. received between the results on the eco router results and the official dex website...

image

Sushiswap image

Uniswap image

@MilanVojnovic95 Can you give steps to reproduce it...I can't trigger that behaviour for me it works. Thats very weird since its accurately inaccurate by 200$....

Mi-Lan avatar Dec 01 '22 11:12 Mi-Lan