swapr-dapp icon indicating copy to clipboard operation
swapr-dapp copied to clipboard

feat: connect Expeditions modal to the expeditions api

Open adamazad opened this issue 2 years ago • 5 comments

Summary

Connects the Expeditions modal to the API hosted at https://api.swapr.site/v1.0/documentation

To Test

Testing this feature requires on-chain transactions. In order to claim weekly fragments. User has to deposit or stake $50 or more worth of liquidity on any of the three chains Swapr core supports: Mainnet, Arbitrum and Gnosis Chain.

adamazad avatar Sep 06 '22 11:09 adamazad

Deploy Preview for swapr failed.

Name Link
Latest commit fd103189dae4c8f2f7e2db4582976516eef06175
Latest deploy log https://app.netlify.com/sites/swapr/deploys/639fac26408e72000909c45f

netlify[bot] avatar Sep 06 '22 11:09 netlify[bot]

Doing some testing, here are some findings and suggested changes. All of the below were tested on Gnosis Chain:

  1. I deposited roughly $200 of GNO/DXD liquidity, which didn't cause the "Provide liquidity" task to complete. Upon staking that balance, the "Stake liquidity" task was completed. Currently unsure what the cause may have been.

image

Depositing liq: https://gnosisscan.io/tx/0x84a9483570a1a028be907252242dad386e80c532563a06acbf64ef47853a05a4 Staking liq in campaign: https://gnosisscan.io/tx/0x11e58a7bf5a4cc1ccc6d083b73f15fdb97fd3f9e307719b113fea63dce5ddc51

  1. Flow for completing a task is exceptional. Looks great. Any way we can implicate a timer until the next weekly tasks unlock? EG: CLAIMED -- NEW TASK IN 2d 4h

image

  1. I've adjusted the design for the switch between Action and Rewards to keep the current fragment balance sticky. This can be found in the design working doc, here: https://www.figma.com/file/R1ibNl3sv1KoQ2BTO7qDBC/Keenan-Working-Sheet?node-id=1672%3A5180

image

  1. Could we add a dynamic element to the Expeditions icon for when a task (or reward?) is claimable? I interpret this as a glow that fades in and out over a 2-second loop, but leave the decision up to @0xVenky.

image

Besides the above, functionally this seems sound. Great stuff! The next step is Rewards and how to test the claiming process of some dummy NFT's I'd reckon. Speak on a call soon!

KeenanLukeOM avatar Sep 13 '22 18:09 KeenanLukeOM

@KeenanLukeOM

  1. Flow for completing a task is exceptional. Looks great. Any way we can implicate a timer until the next weekly tasks unlock? EG: CLAIMED -- NEW TASK IN 2d 4h

So for each completed task user would see a timer on the button showing the same countdown. Maybe instead, we can show the number of current week + single timer until week ends? For example it would be below 'Learn more' sign It would also suggest when new tasks will be available.

image

  1. Could we add a dynamic element to the Expeditions icon for when a task (or reward?) is claimable? I interpret this as a glow that fades in and out over a 2-second loop, but leave the decision up to @0xVenky.

Something like this?

Screencast from 15-09-22 01:32:40.webm

0xVance avatar Sep 15 '22 00:09 0xVance

@0xVance

So for each completed task user would see a timer on the button showing the same countdown. Maybe instead, we can show the number of current week + single timer until week ends? For example it would be below 'Learn more' sign It would also suggest when new tasks will be available.

My interpretation is that showing the time until the specific action is available again scales better, since we have been discussing a daily campaign, event-specific campaigns, etc. I defer to you folks on the team, but I would personally be for a way of indicating the time until the next claim directly in or around that task.

Something like this?

This is exactly what I had envisioned! Any thoughts from your end? Chatted with @zamli about how this could be visualized so defer a decision to him.

KeenanLukeOM avatar Sep 15 '22 01:09 KeenanLukeOM

My interpretation is that showing the time until the specific action is available again scales better, since we have been discussing a daily campaign, event-specific campaigns, etc. I defer to you folks on the team, but I would personally be for a way of indicating the time until the next claim directly in or around that task.

Fair enough, I had only weekly challenges in mind and forgot about daily and other possible tasks.

This is exactly what I had envisioned! Any thoughts from your end? Chatted with @zamli about how this could be visualized so defer a decision to him.

Personally I love it, it could stay like this all the time :sunglasses:

0xVance avatar Sep 16 '22 00:09 0xVance