swapr-dapp icon indicating copy to clipboard operation
swapr-dapp copied to clipboard

Possibility of removing liquidity process after removing max liquidity

Open MilanVojnovic95 opened this issue 2 years ago • 0 comments

Description After removing (MAX) liquidity buttons 'Approve' and 'Remove' are still active and it is possible to click but when it comes to confirm modal window there is no possibility to finish process.

Definition of done

  • [ ] Description is created (Task creator)
  • [ ] Code is complete (Developer)
  • [ ] Scope of test and what was done section is defined in task (Developer)
  • [ ] Review passed (Code reviewer)
  • [ ] Verified manually (QA)
  • [ ] Test cases created/updated if necessary (QA)
  • [ ] Change successfully merged
  • [ ] Release notes added if needed

How to Reproduce Steps to reproduce the behaviour:

  1. Go to Liquidity page
  2. Click on some pair
  3. Click on 'Remove liquidity' button
  4. Selects 'Max' option in Remove liquidity modal window
  5. Click 'Approve'
  6. Click 'Remove'
  7. Click on 'Confirm'
  8. Wait for transaction confirmation notification
  9. Selects 'Max' option in Remove liquidity modal window
  10. Click 'Approve'
  11. Click 'Remove'
  12. Click on 'Confirm' but nothing is happening

Expected behaviour User should not be able to select 'Max' or any other option in removing liquidity modal after removing max liquidity fro certain pair.

Screenshots

https://user-images.githubusercontent.com/57331244/177542947-6e53d54a-89cc-4293-9e8f-4bc00710022f.mp4

Additional context Bug found on swapr.site

MilanVojnovic95 avatar Jul 06 '22 11:07 MilanVojnovic95