Swapnil Rustagi
Swapnil Rustagi
@kanishk98 My VS versions are right, actually the problem is even after I configure `"interactive-notifications": {"protocol": "zulip://"}` in `package.json` in the `zulip-electron` folder, for some reason the install scripts do...
@rrhythmsharma Yes, actually while doing `git commit` the linter ran and gave errors, but there is no point in fixing the issues found by ESLint because, at present notifications are...
@rrhythmsharma That's interesting. Which module were you working with? In my case, it was not working, I put a `log` statement just before and just after the function call and...
@kanishk98 @rrhythmsharma OK it turns out that installing `electron-windows-notifications` via npm is not enough to use it in an Electron app. You need to follow the instructions here: https://github.com/electron/electron/blob/v0.37.2/docs/tutorial/using-native-node-modules.md#using-native-node-modules Also,...
@akashnimare Yes, probably when an installable version is made by electron-builder it won't be an issue, but for the development version which is run by `npm run dev` I think...
I want to implement this, but I am not able to find the time right now. I will be able to continue working on this after a week. Both `electron-windows-notifications`...
@akashnimare I would really like to work on this, but I won't be able to find time till selected students for Google Summer of Code are announced because I am...
@akashnimare Is somebody else working on this? Or can I continue working on this?
@priyank-p @akashnimare I finally got inline replies working - although I am using a work-around which leads to display of two notifications. This PR is not ready to merge yet,...
@akashnimare Please review.