swagger2markup
swagger2markup copied to clipboard
Unit tests containing paths fail on Windows
Some unit tests comparing paths fail on Windows:
org.junit.ComparisonFailure: expected:<"definitions[/]DefinitionName.adoc"> but was:<"definitions[\]DefinitionName.adoc">
This happens on Windows 10 Pro build 1607 and JDK 8u112
Not all tests containing paths seem to fail, so far I have identified the following:
-
AsciidocConverterTest#testMarkupRenderingInInstagram
-
internal.resolver.DefinitionDocumentResolverDefaultTest#testWithSeparatedDefinitionsAndInterDocumentCrossReferences
-
internal.resolver.DefinitionDocumentResolverFromOperationTest#testWithSeparatedOperationsAndInterDocumentCrossReferences
-
internal.resolver.DefinitionDocumentResolverFromOperationTest#testWithSeparatedOperationsAndSeparatedDefinitionsAndInterDocumentCrossReferences
-
internal.resolver.OperationDocumentNameResolverTest#testWithSeparatedOperationsAndInterDocumentCrossReferences
-
internal.resolver.OperationDocumentNameResolverTest#testWithSeparatedOperations
-
internal.resolver.OperationDocumentResolverDefaultTest#testWithSeparatedOperationsAndInterDocumentCrossReferences
All other tests pass
Thx. Yes I have to use the system line separator in the Assertj assert statements.
Hi, I fixed the *ResolverTests.
Could you please paste me the file diff of the AsciidocConverterTest#testMarkupRenderingInInstagram
test?
Before pulling your latest commit
After pulling your latest commit
It seems AsciidocConverterTest#testMarkupRenderingInInstagram
is the only remaining test that doesn't pass after pulling 022d245
The diff is the same between running the test with or without your commit.
Yes, thx
Hi there, is it still open ? I can work on this.
@aspekt23 I haven't made any progress on this since the last update.
Yes, seems so. If you want to do more PRs on Swagger2Markup, I can invite you to our Slack channel