swagger2markup icon indicating copy to clipboard operation
swagger2markup copied to clipboard

Unit tests containing paths fail on Windows

Open cascer1 opened this issue 7 years ago • 8 comments

Some unit tests comparing paths fail on Windows:

org.junit.ComparisonFailure: expected:<"definitions[/]DefinitionName.adoc"> but was:<"definitions[\]DefinitionName.adoc">

This happens on Windows 10 Pro build 1607 and JDK 8u112

Not all tests containing paths seem to fail, so far I have identified the following:

  • AsciidocConverterTest#testMarkupRenderingInInstagram
  • internal.resolver.DefinitionDocumentResolverDefaultTest#testWithSeparatedDefinitionsAndInterDocumentCrossReferences
  • internal.resolver.DefinitionDocumentResolverFromOperationTest#testWithSeparatedOperationsAndInterDocumentCrossReferences
  • internal.resolver.DefinitionDocumentResolverFromOperationTest#testWithSeparatedOperationsAndSeparatedDefinitionsAndInterDocumentCrossReferences
  • internal.resolver.OperationDocumentNameResolverTest#testWithSeparatedOperationsAndInterDocumentCrossReferences
  • internal.resolver.OperationDocumentNameResolverTest#testWithSeparatedOperations
  • internal.resolver.OperationDocumentResolverDefaultTest#testWithSeparatedOperationsAndInterDocumentCrossReferences

All other tests pass

cascer1 avatar Dec 08 '16 15:12 cascer1

Thx. Yes I have to use the system line separator in the Assertj assert statements.

RobWin avatar Dec 08 '16 16:12 RobWin

Hi, I fixed the *ResolverTests. Could you please paste me the file diff of the AsciidocConverterTest#testMarkupRenderingInInstagram test?

RobWin avatar Dec 09 '16 08:12 RobWin

Before pulling your latest commit

After pulling your latest commit

It seems AsciidocConverterTest#testMarkupRenderingInInstagram is the only remaining test that doesn't pass after pulling 022d245

cascer1 avatar Dec 09 '16 09:12 cascer1

The diff is the same between running the test with or without your commit.

cascer1 avatar Dec 09 '16 09:12 cascer1

Yes, thx

RobWin avatar Dec 09 '16 09:12 RobWin

Hi there, is it still open ? I can work on this.

aspekt23 avatar Oct 19 '18 10:10 aspekt23

@aspekt23 I haven't made any progress on this since the last update.

cascer1 avatar Oct 22 '18 09:10 cascer1

Yes, seems so. If you want to do more PRs on Swagger2Markup, I can invite you to our Slack channel

RobWin avatar Oct 22 '18 10:10 RobWin