ComfyUI_Comfyroll_CustomNodes icon indicating copy to clipboard operation
ComfyUI_Comfyroll_CustomNodes copied to clipboard

XY Grid save image grid from folder missing the last image

Open jesenzhang opened this issue 1 year ago • 5 comments

I followed the video https://www.youtube.com/watch?v=81R8mgYhq_k, make the XY Grid as bellow, image but,got this result,missing the last one , did I make any mistake? image

jesenzhang avatar Jan 25 '24 03:01 jesenzhang

Hi. Yes, this a problem with the original design, the XY grid image generates before the last image completes generation I need to rework these nodes when i get some time There is a solution that fixes this, please see this demo as an example: https://raw.githubusercontent.com/Suzie1/ComfyUI_Comfyroll_CustomNodes/main/workflows/XY%20Grid/CR_XY_Revised_FreeU_demo1.json Suzie

Suzie1 avatar Jan 25 '24 10:01 Suzie1

Hi. Yes, this a problem with the original design, the XY grid image generates before the last image completes generation I need to rework these nodes when i get some time There is a solution that fixes this, please see this demo as an example: https://raw.githubusercontent.com/Suzie1/ComfyUI_Comfyroll_CustomNodes/main/workflows/XY%20Grid/CR_XY_Revised_FreeU_demo1.json Suzie

Hello @Suzie1 thank you for this amazing XY Anything pack. I use it a LOT.

And yes, the last image issue is quite annoying.

From this fix you just shared, where is the difference? I cannot see where is the trick.

Again, thank you for your work :)

Latentnaut avatar Jan 25 '24 14:01 Latentnaut

Hi. Yes, this a problem with the original design, the XY grid image generates before the last image completes generation I need to rework these nodes when i get some time There is a solution that fixes this, please see this demo as an example: https://raw.githubusercontent.com/Suzie1/ComfyUI_Comfyroll_CustomNodes/main/workflows/XY%20Grid/CR_XY_Revised_FreeU_demo1.json Suzie

From what I can tell it is triggering the CR XY From Folder node one step too early. For example, I have CR XY List with 5 x variables and 2 Y variables, it should create the XY from folder after image 10 is done. In this case though it triggers after image 9 is done.

If you run it once you will now have 10 files in the folder and a grid that only shows 9. If you run it again, it will make a grid of all 10 because all the images are there already when you trigger it.

Wonderflex avatar Feb 06 '24 19:02 Wonderflex

Hi. Yes, this a problem with the original design, the XY grid image generates before the last image completes generation I need to rework these nodes when i get some time There is a solution that fixes this, please see this demo as an example: https://raw.githubusercontent.com/Suzie1/ComfyUI_Comfyroll_CustomNodes/main/workflows/XY%20Grid/CR_XY_Revised_FreeU_demo1.json Suzie

From what I can tell it is triggering the CR XY From Folder node one step too early. For example, I have CR XY List with 5 x variables and 2 Y variables, it should create the XY from folder after image 10 is done. In this case though it triggers after image 9 is done.

If you run it once you will now have 10 files in the folder and a grid that only shows 9. If you run it again, it will make a grid of all 10 because all the images are there already when you trigger it.

Well, it works, but you have to run it twice, which sometimes that's time consuming.

@Suzie1 what solution do you suggest?

Latentnaut avatar Feb 12 '24 09:02 Latentnaut

Hi. Yes, this a problem with the original design, the XY grid image generates before the last image completes generation I need to rework these nodes when i get some time There is a solution that fixes this, please see this demo as an example: https://raw.githubusercontent.com/Suzie1/ComfyUI_Comfyroll_CustomNodes/main/workflows/XY%20Grid/CR_XY_Revised_FreeU_demo1.json Suzie

Step1: make everyone use the CR Image Output node Step2: take over the world Step3: PROFIT!?!

This is the conspiracy theory I'm going with, here! :b

ps: thanks for keeping my ocd in place. I was plotting an extra line just to have the ones I actually needed

GrigJr avatar Feb 22 '24 16:02 GrigJr