SuuperW

Thanks for your feedback. I had tried to figure out how PolySharp was getting into the project, but couldn't find it. > > Add a reference to BizHawk.Client.EmuHawk [...] >...

I've force-pushed with new commits, this time Lua scripts are run in tests. The first several commits are all refactoring so that the code needed for the test can be...

I realized that this broke drawing via external tools (which already wasn't working as semi-documented anyway, but another undocumented way). My new commits address this issue by allowing external tools...

Thanks for sharing those. So, I guess we want to keep the old WithSurface behavior to preserve compatibility with these tools and any others people may have made? I just...

Okay, new force push reverts the changes to IGuiApi. There are now no changes to how external tools draw. To summarize, the behavior changes in this PR are: 1) Drawing...

Regarding point 2, that attribute is internal so I cannot use it.

I think it would be good to handle the case where the specified branch doesn't exist. So that `tastudio.getmarker(0, 500)` doesn't throw an exception. Maybe print a message saying no...

Actually, branches have an `Id` that can be obtained with `tastudio.getbranches` and this is used instead of an index in `tastudio.getbranchinput`. This seems like it could be useful as branch...

> throwing less I don't really like the idea of using the current marker set when the given branch ID doesn't exist. I also think that the documentation given to...

I played around with this, and I was surprised to find that `tastudio.find_marker_on_or_before(5, "x")` returned `0` instead of `nil`. And so does `tastudio.find_marker_on_or_before(5, 1)`. I also found that `tastudio.find_marker_on_or_before(-1)` throws...