Sergii Gnatiuk
Sergii Gnatiuk
Hi @rrourke Thank you for this awesome work! Still investigating your PR.
The plugin is applied to itself. It reported that coverage is not enough. But please, don't increase the coverage ritght now. Wait until I finish my investigation. Seems, Maven doesn't...
Hi @eamon-t-2023 Could you please clarify > the problem is that diff coverage for each sub module may include data from other sub modules. What do you mean `may include...
Hi @shubhampanchal21109 Seems, you are old java 8. Diff coverage uses jgit library for generating patch file. Seems, the was compiled with target java version 11. ---- If you have...
@eamon-t-2023 Suppose `B` depends on `A`. - When you trigger diff report generation on module `A` then expected reports is generated only for `A`. - When trigger diff report generation...
Hi @eamon-t-2023 First of all, thank you for the example. It helped a lot to understand the root cause. The plugin was not designed to apply to each module, that's...
Hi @praveen-kumar85 ## Workaround I solved the issue you discribed in the next way: 1. Declare a property in pom.xml: ```xml ... true ... ``` 2. Setup the plugin to...
If the approach above doesn't suitable for you then await few days(up to 2 weeks) while I implement the feature you ask.
@praveen-kumar85 Going to implement the feature you requested. Here example how it could be configured: https://github.com/SurpSG/diff-coverage-maven-plugin/pull/50/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R62 I would be pleased to receive feedback
Hi @slice-imran The plugin checks only new and modified code. `minLines` - lines of code coverage ratio `minBranches` - branching coverage ratio(e.g. `if-else`, `?:`) `minInstructions` - java bytecode coverage Usually,...