swagger-jsdoc icon indicating copy to clipboard operation
swagger-jsdoc copied to clipboard

Use Semantic release to publish release notes and to NPM

Open superflyxxi opened this issue 2 years ago • 6 comments

superflyxxi avatar Apr 01 '22 22:04 superflyxxi

can we add a previous step to ask if we want to release it? Then, only when allowing the publish will be called?

daniloab avatar Apr 18 '22 14:04 daniloab

Yeah. I'll have to look into how to do that with git flows. You want a manual approval step before it attempts to publish.

superflyxxi avatar Apr 25 '22 10:04 superflyxxi

The closest I found was this: https://docs.github.com/en/actions/managing-workflow-runs/reviewing-deployments and this https://cloudlumberjack.com/posts/github-actions-approvals/

I guess if we set up a production npm "Environment" in github, you can configure it to require approvals. In that "Environment", you can add a secret for NPM_AUTH_TOKEN. Finally, I can have the github action references that "Environment" to fetch its secret. And it would require approval before it happens.

How does it sound?

superflyxxi avatar May 05 '22 00:05 superflyxxi

The closest I found was this: https://docs.github.com/en/actions/managing-workflow-runs/reviewing-deployments and this https://cloudlumberjack.com/posts/github-actions-approvals/

I guess if we set up a production npm "Environment" in github, you can configure it to require approvals. In that "Environment", you can add a secret for NPM_AUTH_TOKEN. Finally, I can have the github action references that "Environment" to fetch its secret. And it would require approval before it happens.

How does it sound?

I like this flow but the one problem is that I cant create an environment var to the repo. Maybe @chdanielmueller can help us on this to make the release more robust?

daniloab avatar May 05 '22 12:05 daniloab

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jul 04 '22 18:07 stale[bot]

Hey all, what should we do? I'm okay with letting this close.

superflyxxi avatar Jul 04 '22 18:07 superflyxxi

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Sep 02 '22 20:09 stale[bot]