Supun Setunga

Results 120 comments of Supun Setunga

With restricted types being replaced with interface-set, the proposed method looks very similar to the existing `.isSubType()` method: Proposed: ```cadence smolBeanTy.conformsTo(Interface()) ``` Existing: ```cadence smolBeanTy.isSubType(of: Type()) ``` Thus, I don't...

This was already proposed sometime back and also has the implementation: https://github.com/onflow/cadence/pull/1253 However, it was put on hold due to the feedback received. Maybe we could re-ignite the discussion.

But even with that, the problem is, the destructor is forced to run whenever a resource is cleaned-up from storage, and that would need to load the resource and run...

Another option is to make the storage interaction functions handle errors gracefully. i.e: not to panic, but rather return `nil` if something goes wrong. (Or provide a global way of...

Capturing some more suggestions came up during the PR review: - [ ] Replace `oneOf` with `or` (https://github.com/onflow/cadence/pull/4262#discussion_r2457356952) - [ ] Split YAML file with anchors (https://github.com/onflow/cadence/pull/4262#discussion_r2457375989) - [x] Add...

Just to make sure I understand correctly, the idea here is that: - Cadence will continue to report fine-grained errors - But they will be converted to more coarse-grained errors,...

@RZhang05 I believe you've already added this in https://github.com/onflow/cadence/pull/3594 (still open)?

oh wow, I piggy-back on this updated test to compare the interpreter (`master`), vm (`master`), and optimized-vm (https://github.com/onflow/cadence/pull/4322), and the results are: ``` goos: darwin goarch: arm64 pkg: github.com/onflow/cadence/runtime cpu:...

Would need a second pair of eyes on the conflicts resolving

Related: https://github.com/onflow/cadence/pull/4054 (particularly https://github.com/onflow/cadence/pull/4054#discussion_r2172847539)