superblocks-lab
superblocks-lab copied to clipboard
Project doesn't get forked when deleting/adding files in temporary projects
Environment/Browser
Production 1.6.1
Description
When you load project from ipfs and delete any file, it won't get forked. Same goes for creating new file/folder.
Steps to reproduce
- Open up https://lab.superblocks.com/ipfs/QmTUtK2NPgA9hLzEq5eQoBVAp3JoEnP5A9GKVLingkaGE3
- Try to delete
README.md
or add new folder - Observe project not being forked
Expected result
After step 2. it should get forked. Similar case when you modify any file it gets automatically forked.
Actual result
Project not forked
Reproducible
100%
Confirmed it only forks after the Save action gets triggered (or after clicking the Fork button). According to the original request (#322):
Verification Process [...] click on the fork button or save the project.
Code reference: the action is getting called in Editor
class (save
).
Manually clicking the Fork button always returns "Project Forked!" with the appropriate data for the following cases:
- add New File
- add New Folder
Other relevant actions to consider when looking at this issue:
-
Configure changes data (and it is not an
Editor
save action. It is a different save action.) -
Compile potentially creates new files
- Should the project automatically fork in that case as well ? Before or after Compile ?
- Is the build directory still to be considered when forking ?
-
Deploy has the ability to create new files
- Would the project automatically fork in that case too ? Before or after deployment has finished ?
- Is the build directory still to be considered when forking ?