ethereum-studio icon indicating copy to clipboard operation
ethereum-studio copied to clipboard

Hide UI inputs until contract is deployed

Open samajammin opened this issue 4 years ago • 4 comments

Summary

We should hide all inputs from the browser UI until a contract has actually been deployed.

Motivation

Currently if a user attempts to interact with the UI before deploying the contract, the loader spins indefinitely (for Hello World template: https://share.getcloudapp.com/DOuQwYbj) or the input does nothing (for Coin & CryptoPizza templates). This could create a potentially confusing interaction for the user.

Describe alternatives you've considered

None

Additional context

None

samajammin avatar Apr 15 '20 17:04 samajammin

@samajammin Do you know if anyone has picked this up yet? For starters, I was going to update app.js in the Hello World template to be more defensive about accessing methods off of this.instance. I'd be happy to try to write a PR to hold off on rendering UI inputs until the contract has been deployed as well.

nathan-lapinski avatar May 09 '20 04:05 nathan-lapinski

@nathan-lapinski PRs definitely welcome! Thank you for offering!

samajammin avatar May 10 '20 17:05 samajammin

@samajammin Thank you for the opportunity to contribute! I'll start looking into it this evening, and add a PR once it is ready.

nathan-lapinski avatar May 12 '20 05:05 nathan-lapinski

Thanks @nathan-lapinski for the help :)

Looking forward to that PR!

javier-tarazaga avatar May 20 '20 06:05 javier-tarazaga