ethereum-studio icon indicating copy to clipboard operation
ethereum-studio copied to clipboard

Check before deploying contract containing non-payable constructor configured with non-zero value

Open filippsen opened this issue 5 years ago • 0 comments

Summary

Request #146 adds a new Value configuration to enable sending funds as part of contract deployment. There is nothing preventing deployment attempts when the Value is set and the constructor is not payable. Deploying a contract non-payable constructor leads to:

Transaction mined, verifying code...
Contract code could not be verified on chain. The contract might not have been deployed.
This is possibly a mismatch in the number/type of arguments given to the constructor or could
also be a temporary issue in reading back the contract code from the chain.

It would be more correct to verify the Value configuration matches a (expected) payable constructor before proceeding with the Deploy action.

filippsen avatar Nov 15 '19 14:11 filippsen