laravel-google-cloud-storage icon indicating copy to clipboard operation
laravel-google-cloud-storage copied to clipboard

Published 20 hours ago • verified publisher icon Superbalist

Fix issue #60: keyFile in config (#60)

Open ralfiannor opened this issue 5 years ago • 3 comments

Fix logic if keyFile is null

ralfiannor avatar Apr 25 '19 08:04 ralfiannor

@nicja thoughts on trying to get some tests in here? I'm wondering if @ralfiannor should perhaps at least add a test for the config merging, but that would require some setup on your side to get a pipeline running.

phroggyy avatar May 09 '19 14:05 phroggyy

Confirmed that this fix works for a GKE-powered environment with creds provided at the instance level. Had the same issue mentioned in #68. I'll fork off of this branch and a test that fails prior to this commit and succeeds with the commit if that's what it takes to get this merged.

iansltx avatar Aug 08 '19 09:08 iansltx

If this fixes #60, then please could it be merged in? cc @nikolaos-spyratos, @alihen

trovster avatar Mar 18 '20 07:03 trovster