SuperTux
Item Pocket
The Item Pocket allows you to save a powerup for later use. If you collect a flower while having a bonus greater than GROWUP_BONUS, that flower gets equipped and the old flower gets stored in the top left corner of the screen. Now, the player can press the new ITEM control (usually Select/Back or Left Shift) to use the stored flower by throwing it up and catching it.
This pull request replaces the powerup stacking feature because this new solution is much more balanced. It also limits the amount of concurrent players to 4.
Please fix initialization order:
/Users/runner/work/supertux/supertux/src/supertux/player_status.cpp:38:3: error: field 'bonus' will be initialized after field 'm_item_pockets' [-Werror,-Wreorder-ctor]
bonus(num_players),
^~~~~~~~~~~~~~~~~~
coins(START_COINS)
/home/runner/work/supertux/supertux/src/badguy/boss.cpp:76:70: error: implicit conversion from 'int' to 'float' may lose precision [-Werror,-Wimplicit-int-float-conversion]
float startpos = (context.get_width() - (m_hud_head->get_width() * m_max_lives)) / 2;
Has the ability to disable the itembox been discussed?
What do you mean by disabling it...? It's a core gameplay feature
What do you mean by disabling it...? It's a core gameplay feature
Pardon? I meant that some level designers may want to disable it for themselves (or per world). I am curious on the consensus. I personally wouldnt enable it for my worlds
Found tiny bug: after I played through a level and went back to the worldmap, the item pocket visually disappears while on the worldmap. It does come back when entering a level, but goes away again afterwards.
The blinking effect indicates that you can't pick it up yet. This is a mechanism that prevents immediately grabbing the object upon jumping.
Also, I think the general consensus is that it shouldn't move in x axis whatsoever but I might be wrong so I'll leave this up for discussion.
Can you check if power up stacking was truly removed in case I missed something?
seems theres a bug with the item pocket that makes it so theres multiple item pockets when theres only one player
