supertux icon indicating copy to clipboard operation
supertux copied to clipboard

Improved Flame

Open Sevenberry opened this issue 1 year ago • 4 comments

Added colored flames, interaction with magic tiles, and flame particle trails.

Sevenberry avatar Jul 07 '24 23:07 Sevenberry

First!

Rusty-Box avatar Jul 07 '24 23:07 Rusty-Box

 src/object/moving_sprite.cpp:260:19: style: Redundant assignment of 'angle' to itself. [selfAssignment]
      float angle = angle;
                  ^
src/object/moving_sprite.cpp:260:21: error: Uninitialized variable: angle [legacyUninitvar]
      float angle = angle;
                    ^

tobbi avatar Jul 08 '24 09:07 tobbi

/Users/runner/work/supertux/supertux/src/badguy/flame.hpp:31:16: error: 'after_editor_set' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
  virtual void after_editor_set();
               ^
/Users/runner/work/supertux/supertux/src/badguy/badguy.hpp:76:16: note: overridden virtual function is here
  virtual void after_editor_set() override;
               ^
/Users/runner/work/supertux/supertux/src/badguy/flame.cpp:39:3: error: field 'lightcolor' will be initialized after field 'sound_source' [-Werror,-Wreorder-ctor]
  lightcolor(1.0f, 1.0f, 1.0f),

tobbi avatar Jul 08 '24 09:07 tobbi

I seem quite the party-pooper by only pointing out compiler errors. Sorry about that.

tobbi avatar Jul 08 '24 09:07 tobbi