supertux icon indicating copy to clipboard operation
supertux copied to clipboard

Prevent infinite recursion in rock's grab and ungrab scripts

Open tobbi opened this issue 1 year ago • 4 comments

This prevents #2906 from happening, however: It also creates infinite flipping and unflipping and I haven't figured out the cause yet. That's why I'm marking it as a draft. If anyone has any idea, go ahead.

tobbi avatar Apr 15 '24 08:04 tobbi

I think the PR is fine; I just set a script like this in order to prevent it from running infinitely: image

weluvgoatz avatar Apr 15 '24 13:04 weluvgoatz

However this PR does fix the crash. Thank you!!!!

weluvgoatz avatar Apr 15 '24 13:04 weluvgoatz

I'd really like to fix the flickering issue as well so that it only flips once.

tobbi avatar Apr 15 '24 15:04 tobbi

Not sure if possible since the script seems to run every frame while the rock is being held, rather than just when you first hold it.

weluvgoatz avatar Apr 15 '24 17:04 weluvgoatz

I think the solution might be easier than I initially thought.

tobbi avatar May 29 '24 09:05 tobbi