supertux icon indicating copy to clipboard operation
supertux copied to clipboard

Small "shaky" pause when dying

Open n0toose opened this issue 1 year ago • 8 comments

Mario games and other platformers like Celeste or Kirby have this thing where the screen and the entire world shake a little bit, a music pause, a vibration or a screen shake when "dying".

Deaths currently feel more like as if you're being teleported back to the checkpoint / beginning of the level, and I begin to realize that halfway through the death animation.

The game already seems to have some features that could be put together to make something like this, such as the screen shake when buttjumping, as well as controller rumble.

I watched this video from Masahiro Sakurai close to a year ago, and this was one of the things that always felt somewhat off but could not exactly point out why - I did play Kirby's Adventure when I was younger and that is an effect that I'd like to see imitated: https://youtube.com/watch?v=OdVkEOzdCPw

n0toose avatar Jan 24 '24 12:01 n0toose

This was in the game as of recently, but was removed due to it being generally disliked by the community.

Vankata453 avatar Jan 24 '24 13:01 Vankata453

This was in the game as of recently, but was removed due to it being generally disliked by the community.

Oh, a "damned if I do, damned if I don't" situation - sorry for the duplicate. Is it possible that there may be a compromise / that the previous implementation was somehow faulty in a way that could be salvaged and that the shake needed to be combined with something else?

On 0.6.3, it feels like there's an explosion happening when I die (which was fixed here: https://github.com/SuperTux/supertux/pull/2575). I will take a look at https://github.com/SuperTux/supertux/pull/2522 on a custom branch and return with feedback.

n0toose avatar Jan 24 '24 13:01 n0toose

Okay, the shake is kind of intense and doesn't really involve a pause - I think that could be possibly improved by reducing the intensity and the duration, and combining it with something else.

But if that's a wontfix, I can respect that.

n0toose avatar Jan 24 '24 13:01 n0toose

Oh, a "damned if I do, damned if I don't" situation - sorry for the duplicate. Is it possible that there may be a compromise / that the previous implementation was somehow faulty in a way that could be salvaged and that the shake needed to be combined with something else?

The only way I can think of to have this feature is to make it optional via a setting. That setting could also be combined with the aforementioned controller rumble, if it's added as well.

Vankata453 avatar Jan 24 '24 13:01 Vankata453

The only way I can think of to have this feature is to make it optional via a setting.

I think this is a good approach. I think I'll start working on it after my workload lightens up a little bit.

Just one more question: What do you think of this death screen? https://yewtu.be/watch?v=hF8moB-ONRY

n0toose avatar Jan 24 '24 13:01 n0toose

I think I'll start working on it after my workload lightens up a little bit.

Nice! However, I'm thinking this may need more discussion before it's actually re-implemented.

Vankata453 avatar Jan 24 '24 13:01 Vankata453

Oh, a "damned if I do, damned if I don't" situation - sorry for the duplicate. Is it possible that there may be a compromise / that the previous implementation was somehow faulty in a way that could be salvaged and that the shake needed to be combined with something else?

The only way I can think of to have this feature is to make it optional via a setting. That setting could also be combined with the aforementioned controller rumble, if it's added as well.

Adding to this, a setting for how intense the screenshake is would also be nice.

tylerandari13 avatar Jan 24 '24 13:01 tylerandari13

I'm thinking this may need more discussion before it's actually re-implemented.

Adding to this, a setting for how intense the screenshake is would also be nice

I think that this should be the last thing to do.

I think that making something that is very soft (like a shoulder pat, instead of an earthquake) and barely noticeable - in a way that looks OK on both smaller and bigger screens - would a good first step - while making it disabled by default for now. Then, figuring out other things (such as how to get controller rumbling involved - or maybe doing that first), or maybe having a different kind of shake depending on the death would be better before introducing the setting.

n0toose avatar Jan 24 '24 13:01 n0toose