supertux icon indicating copy to clipboard operation
supertux copied to clipboard

Rework CMake enviroment

Open MatusGuy opened this issue 1 year ago • 30 comments

Fixes #2619

MatusGuy avatar Aug 31 '23 10:08 MatusGuy

...

tobbi avatar Aug 31 '23 10:08 tobbi

@tobbi sorry if it looks weird im just getting things ready

MatusGuy avatar Aug 31 '23 17:08 MatusGuy

I think you're doing this to troll people.

But the more I look at it, the more I'm convinced that this is "the pull request" I've mentioned for the longest time. Congratulations. I may have to reverse my decisions about this being the pull request.

tobbi avatar Aug 31 '23 18:08 tobbi

But the more I look at it, the more I'm convinced that this is "the pull request" I've mentioned for the longest time.

If this is the pull request, then whats "the issue"?

Edit: i think its #2619

tylerandari13 avatar Aug 31 '23 19:08 tylerandari13

@tobbi ill prove it to you

MatusGuy avatar Aug 31 '23 23:08 MatusGuy

i truly shouldn'tve deleted those files like that so sorry to anybody i scared

MatusGuy avatar Sep 01 '23 16:09 MatusGuy

Go back in time and undelete those files.

they arent gonna be used but ok

MatusGuy avatar Sep 01 '23 16:09 MatusGuy

Maybe I should mark my jokes a little better

tobbi avatar Sep 01 '23 16:09 tobbi

tobbi may i clarify that you sounded even grumpier than usual (idk how this is even possible) when you called this a troll

MatusGuy avatar Sep 01 '23 16:09 MatusGuy

FCK

MatusGuy avatar Jan 14 '24 12:01 MatusGuy

ONE DAY! GRUMBEL WILL BE FANUM TAXED DOWN THE SKIBIDI TOILET!!!

MatusGuy avatar Jan 15 '24 22:01 MatusGuy

Marty are you okay

Frostwithasideofsalt avatar Jan 15 '24 22:01 Frostwithasideofsalt

yEA

MatusGuy avatar Jan 15 '24 22:01 MatusGuy

Despite all odds, theres still 1 successful commit.

tylerandari13 avatar Jan 15 '24 22:01 tylerandari13

Do y'all think it'd be a good idea to use FetchContent instead of git submodules?

MatusGuy avatar Feb 15 '24 20:02 MatusGuy

Do y'all think it'd be a good idea to use FetchContent instead of git submodules?

I'd prefer submodules, because with them I can edit the source code of dependencies locally and compile with the game right away.

Vankata453 avatar Feb 15 '24 21:02 Vankata453

... and you can do that fetchcontent too. All fetchcontent does is download a zip and uncompress it. It's better than submodules because you're not cloning the history of the repository, you're just downloading a zip.

MatusGuy avatar Feb 15 '24 21:02 MatusGuy

Do y'all think it'd be a good idea to use FetchContent instead of git submodules?

I don't know but here's a German reddit thread about the worst drug experiences: https://old.reddit.com/r/FragReddit/comments/1arfobr/was_war_eure_schlimmste_erfahrung_mit_drogen/

tobbi avatar Feb 15 '24 21:02 tobbi

Tobbi what the fuck

MatusGuy avatar Feb 15 '24 21:02 MatusGuy

... and you can do that fetchcontent too. All fetchcontent does is download a zip and uncompress it. It's better than submodules because you're not cloning the history of the repository, you're just downloading a zip.

Then I would be fine with it. However, perhaps managing the commit, pointed to, is easier with submodules? Otherwise, you probably have to edit it from the CMake file. But it likely wouldn't be an issue.

Vankata453 avatar Feb 15 '24 21:02 Vankata453

Do you want to push the changes in the submodules?

MatusGuy avatar Feb 15 '24 21:02 MatusGuy

Actually, yeah. I definitely see it as more convenient.

Vankata453 avatar Feb 15 '24 21:02 Vankata453

fetchcontent or pushing from submodule?

MatusGuy avatar Feb 15 '24 21:02 MatusGuy

Pushing from submodule, as you mentioned. I can recall doing that a lot.

Vankata453 avatar Feb 15 '24 21:02 Vankata453

Through this PR I learned that you can report code for crypto mining. I just did.

tobbi avatar Feb 15 '24 21:02 tobbi

tobbi this pr will fix all macos ci failures

MatusGuy avatar Feb 15 '24 21:02 MatusGuy

I'll break them again

MatusGuy avatar Feb 15 '24 21:02 MatusGuy

Sometimes you need to tear something down so you can rebuild it from scratch even better.

tylerandari13 avatar Feb 15 '24 21:02 tylerandari13

Sometimes you need to tear something down so you can rebuild it from scratch even better.

I do that a lot with other people. But I won't rebuild them.

tobbi avatar Feb 15 '24 21:02 tobbi

Also remember: There is no market. It's all priced in.

tobbi avatar Feb 15 '24 22:02 tobbi