supertux icon indicating copy to clipboard operation
supertux copied to clipboard

Remove get_pixel API

Open pelya opened this issue 3 years ago • 2 comments

On my old Galaxy Note 3 the FPS dropped to one frame per two seconds the moment a magic block was on screen. GL drivers on Android does not handle reading pixels from the screen at all. The magic blocks should work more or less the same, I have tested the block activation distance on Tower of Ghosts level. Magic blocks are now activated only by lanterns. If there are any community levels that used Live Fire guy to activate magic blocks, they are now broken.

pelya avatar Jan 13 '22 18:01 pelya

Not only Livefire, but also spotlights can activate blocks and that uses the get_pixel API...that's the case in the one forest level that uses magic blocks.

tobbi avatar Jan 14 '22 21:01 tobbi

Tower of Ghosts uses only lanterns, but Ghouls Lair uses a rotating spotlight in a secret area. You still can finish the level if you don't go there. I've added spotlight support to the magic block update code. There are a bunch of levels with magic blocks in bonus packs, I've tried Castle of Light and Darkness, and I could not finish it with the vanilla SuperTux, it just looks broken near the end.

On Fri, Jan 14, 2022 at 11:14 PM Tobias Markus @.***> wrote:

Not only Livefire, but also spotlights can activate blocks and that uses the get_pixel API...that's the case in the one forest level that uses magic blocks.

— Reply to this email directly, view it on GitHub https://github.com/SuperTux/supertux/pull/2085#issuecomment-1013477714, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABF5QFT277BQGEXZURMUCTUWCG35ANCNFSM5L4TM6MA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

pelya avatar Jan 15 '22 22:01 pelya