supertux icon indicating copy to clipboard operation
supertux copied to clipboard

New rock bonus

Open Semphriss opened this issue 4 years ago • 12 comments

Closes #1527

https://user-images.githubusercontent.com/66701383/133940232-c64b7428-462f-4e04-b3e0-4c544c9f5cca.mp4

The feature is not polished, but I open the PR so people can start giving feedback and playing around with it.

Semphriss avatar Sep 19 '21 19:09 Semphriss

I like this but how do we make this not overkill?

tobbi avatar Sep 19 '21 22:09 tobbi

A good first step would be to refactor the player.cpp file to fix the huge technical debt we have.

In all seriousness, to have a better management (better physics on slopes and all) would require a refactor of the player code and the physics engine. It will become increasingly difficult to maintain most player-related features until then.

Semphriss avatar Sep 19 '21 23:09 Semphriss

I suggest to add friction, so if you are not holding any directional key, the rock should begin to slow down. Also, as a rock you should be able to break trough crates.

There were two bugs I encountered: When moving up a 45° slope and leaving rock form Tux keeps the rock hitbox causing his sprite to clip through the floor. When you hold down while being a rock and let go of the action key Tux's standing hitbox appears while he still ducks, causing his sprite to float. This only occurs if you were ducking before turning into a rock.

Rusty-Box avatar Oct 14 '21 09:10 Rusty-Box

I know it's trivial problem, but Tux can't pick up stuff in any way. So if you happen to be in a puzzle level as an Earth Tux you're out of luck.

Zwatotem avatar Oct 14 '21 11:10 Zwatotem

I know it's trivial problem, but Tux can't pick up stuff in any way. So if you happen to be in a puzzle level as an Earth Tux you're out of luck.

Not really. You just cannot turn into a rolling rock. You still can carry stuff and do puzzles using portable objects.

Edit: Oh wait, I forgot. I know what you’re on to. Then that basically suggest we give it the Sonic treatment, i.e. to turn into rock you have to duck/hold the DOWN-key and then press the ACTION-key. That way you can still pick up stuff.

Rusty-Box avatar Oct 15 '21 08:10 Rusty-Box

I'd suggest that you would only turn into a boulder if you were on the ground, and you would instead turn into a statue if you are in the air.

Busybody64 avatar Oct 21 '21 15:10 Busybody64

I think, this is very good, but a bit too overpowered, so i think, it would be good if this ability could only available on slopes, or until full-speed running, and at other cases tux would have a tanooki-statue-like ability.

Guih48 avatar Nov 05 '21 19:11 Guih48

I think, this is very good, but a bit too overpowered, so i think, it would be good if this ability could only available on slopes, or until full-speed running, and at other cases tux would have a tanooki-statue-like ability.

I agree with this statement.

Busybody64 avatar Nov 05 '21 20:11 Busybody64

I think, this is very good, but a bit too overpowered, so i think, it would be good if this ability could only available on slopes, or until full-speed running, and at other cases tux would have a tanooki-statue-like ability.

Like this: https://github.com/SuperTux/supertux/pull/1527#issue-690358030

Guih48 avatar Nov 06 '21 08:11 Guih48

I suggest to add friction, so if you are not holding any directional key, the rock should begin to slow down.

Stone Tux should slow down even when holding a directional key, that would be more fair. So Tux can turn to stone while running, but will stop after some short distance or after bumping into enemy, and there's no control over Tux once he starts rolling. Tux will need some minimal speed to flatten the enemy, if the speed is not enough Tux just stops rolling. And he won't be able to flatten tall enemies at all, like Stumpy or Snowman.

pelya avatar Jan 16 '22 21:01 pelya

So Tux can turn to stone while running, but will stop after some short distance or after bumping into enemy

The problem with this is that Tux can get accidentally stuck in narrow areas without possibility to leave. I added a small movement possible to let Tux creep out of such places, but not in a convenient/satisfying enough way to make it usable through regular gameplay.

Semphriss avatar Feb 27 '22 18:02 Semphriss

That's also a long-standing problem with physics - it doesn't look good when Tux stands up in a narrow area and takes damage, and these little crouching jumps are silly. Make big Tux roll or slide on his belly instead, when he cannot stand up.

On Sun, 27 Feb 2022, 20:39 Semphriss, @.***> wrote:

So Tux can turn to stone while running, but will stop after some short distance or after bumping into enemy

The problem with this is that Tux can get accidentally stuck in narrow areas without possibility to leave. I added a small movement possible to let Tux creep out of such places, but not in a convenient/satisfying enough way to make it usable through regular gameplay.

— Reply to this email directly, view it on GitHub https://github.com/SuperTux/supertux/pull/1820#issuecomment-1053641650, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABF5QGH7TQGXXN647EF2ALU5JVWJANCNFSM5EKUOB2A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you commented.Message ID: @.***>

pelya avatar Feb 27 '22 19:02 pelya

Closing this because I am working on a significantly more expansive and modern version of this PR.

weluvgoatz avatar Oct 07 '22 00:10 weluvgoatz