Ben Kochie

Results 1558 comments of Ben Kochie

Yes, this is looking much better. I'll try and do a deeper review soon.

Yes, that is probably related. I guess we need to update the procfs parsing library.

I think some of the intention here was to better curate the output of these metrics for HELP text and cardinality control.

This was fixed in https://github.com/prometheus/node_exporter/pull/3059

This needs a DCO sign-off. You can use `git commit -s --amend` to add it.

Please do not report raw vulnerability scanner results. They are prone to false positives and cause the maintainers toil in verifying. Please verify vulnerability reports and include specific details as...

Do you mean rate limits? I think this is already solved by [the response rate limit plugin](https://github.com/coredns/rrl) But I highly recommend against using such things in a controlled environment like...

Yes, there are behavior "known issues" with DaemonSets, same problems with using agents like Grafana Alloy and OTel. One of the fatal flaws of push-based metrics systems is that the...

That is no longer a supported cipher due to insecurity. It appears you are just listing all ciphers, it would be easier if you simply removed all of them from...