xoutSetup LogOnlyXout, CoutOnlyXout should not ignore setupLogging, setupCout parameters

Open N-Dekker opened this issue 3 years ago • 0 comments

Please check elxElastixMain.cxx commit 763327c3470affca13944e876b07c9e3f045832a https://github.com/SuperElastix/elastix/blob/763327c3470affca13944e876b07c9e3f045832a/src/Core/Kernel/elxElastixMain.cxx#L66-L89

It seems to me that the following two statements should be surrounded by if( setupLogging ) and if( setupCout ), respectively. Right?

returndummy |= g_LogOnlyXout.AddOutput( "log", &g_LogFileStream );
returndummy |= g_CoutOnlyXout.AddOutput( "cout", &std::cout );

The main question is: Do we want no console output at all from the logger, when the ITKElastix/SimpleITK elastix library property LogToConsole = false? Or do we still want logging directed to "coutonly" to appear on the console anyway?

Feb 03 '23 11:02 N-Dekker