elastix icon indicating copy to clipboard operation
elastix copied to clipboard

Published 20 hours ago • verified publisher icon SuperElastix

Request: improve ElastixConfig for downstream packaging

Open hmaarrfk opened this issue 7 years ago • 3 comments
trafficstars

Hi, it seems that ElastixConfig.cmake is generated using the buildtime location of the source, and not with the install time locations of the directories.

It would be good if you could help generate the output of the files such that they point to their install locations.

hmaarrfk avatar Jun 19 '18 23:06 hmaarrfk

The config files were recently improved in elastix but I am not sure if this is reflected on the SimpleElastix master branch yet. Have you tried the develop branch?

kaspermarstal avatar Jun 22 '18 09:06 kaspermarstal

should this not be optional? People will also choose not to install but link against the build dir, right?

mstaring avatar Jul 16 '18 09:07 mstaring

Two different ElastixConfig.cmake's can be provided -- one that specifies how to build against the build tree, and one that specifies how to build against the install tree. The latter is installed.

Here is how it is done in ITK:

https://github.com/InsightSoftwareConsortium/ITK/blob/95a973c835bec1f66da30eebaaae59d5eee42053/CMakeLists.txt#L438-L474

thewtex avatar Sep 30 '19 17:09 thewtex

Thanks for reporting. As far as I can see, it is fixed by now, by https://github.com/SuperElastix/elastix/pull/655 (by @blowekamp).

Please reopen, if you think otherwise.

N-Dekker avatar Jan 13 '23 15:01 N-Dekker