elastix icon indicating copy to clipboard operation
elastix copied to clipboard

Published 20 hours ago • verified publisher icon SuperElastix

Add macos-14 in CI

Open thewtex opened this issue 2 months ago • 3 comments

This is an ARM architecture mac system aka Apple Silicon.

This will add more compiler checks. In https://github.com/InsightSoftwareConsortium/ITKElastix/pull/278 we also observe numerical differences at the application level -- the test suite might provide more insights.

thewtex avatar Apr 21 '24 20:04 thewtex

@thewtex Thanks for the suggestion, but all I got so far from upgrading to macos-14 (branch https://github.com/SuperElastix/elastix/tree/GitHubActions-macos-14) are extra warnings, at https://my.cdash.org/viewBuildError.php?type=1&buildid=2550398 saying:

ld: warning: ignoring duplicate libraries: '-lm', '/.../ITK-build/lib/libITKCommon-5.4.a', ...

🤷

N-Dekker avatar Apr 26 '24 15:04 N-Dekker

@N-Dekker I addressed these warnings in ITK via https://github.com/InsightSoftwareConsortium/ITK/pull/4519/commits/7231bf793f552517e309a354ee5643b3f2967ed0 -- bumping ITK should do the trick!

thewtex avatar May 07 '24 16:05 thewtex

Now trying to upgrade: https://github.com/SuperElastix/elastix/tree/Upgrade-ITK-to-v5.4rc04

  • Update: just merged: commit 1de1556687e3874ca0b4f00caceb14156e965df2 pull request #1113

N-Dekker avatar May 07 '24 18:05 N-Dekker