zat icon indicating copy to clipboard operation
zat copied to clipboard

Improve log rotation handling

Open brifordwylie opened this issue 7 years ago • 3 comments

Right now the Bro log tailing 'kinda' handles log rotation but there are lots of little corner cases that we're not taking care of. We might consider using something like Pygtail (https://github.com/bgreenlee/pygtail). Looking at the project/code they've put a lot of work into handling all those crazy corner cases.

brifordwylie avatar Jan 01 '18 02:01 brifordwylie

Actually after spending some 'quality time' with Pygtail on another project it doesn't handle some of the use cases we need (rename/create) and the code logic doesn't really support dynamic tailing very well. You can put a wrapper around next that works fine but then weird stuff happens with log rotations not be processed correctly...

brifordwylie avatar Jan 02 '18 18:01 brifordwylie

Just a thought, that might be wide off the mark....

How many users do you think want/need the log tailing? Would it make sense to utilise some other mechanism for the heavy lifting instead?

For example if a heavy/advanced user have a ready Spark/Kafka setup could that be utilised to pull a (more or less) live feed?

As I said, just a thought...

swedishmike avatar Jan 02 '18 19:01 swedishmike

Stale issue message

github-actions[bot] avatar Dec 30 '20 02:12 github-actions[bot]