react-native-extra-dimensions-android icon indicating copy to clipboard operation
react-native-extra-dimensions-android copied to clipboard

Android support gradle 8

Open NoatToan opened this issue 7 months ago • 0 comments

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch [email protected] for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/react-native-extra-dimensions-android/android/build.gradle b/node_modules/react-native-extra-dimensions-android/android/build.gradle
index c470e07..f653760 100644
--- a/node_modules/react-native-extra-dimensions-android/android/build.gradle
+++ b/node_modules/react-native-extra-dimensions-android/android/build.gradle
@@ -10,6 +10,7 @@ def DEFAULT_TARGET_SDK_VERSION = 26
 def DEFAULT_SUPPORT_LIB_VERSION = "27.0.2"
 
 android {
+    namespace "ca.jaysoo.extradimensions"
     compileSdkVersion rootProject.hasProperty('compileSdkVersion') ? rootProject.compileSdkVersion : DEFAULT_COMPILE_SDK_VERSION
     buildToolsVersion rootProject.hasProperty('buildToolsVersion') ? rootProject.buildToolsVersion : DEFAULT_BUILD_TOOLS_VERSION
 
diff --git a/node_modules/react-native-extra-dimensions-android/android/src/main/AndroidManifest.xml b/node_modules/react-native-extra-dimensions-android/android/src/main/AndroidManifest.xml
index cc0f8ba..5fbaa4c 100644
--- a/node_modules/react-native-extra-dimensions-android/android/src/main/AndroidManifest.xml
+++ b/node_modules/react-native-extra-dimensions-android/android/src/main/AndroidManifest.xml
@@ -1,3 +1,3 @@
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
-          package="ca.jaysoo.extradimensions">
+          >
 </manifest>

This issue body was partially generated by patch-package.

NoatToan avatar May 27 '25 12:05 NoatToan