react-native-extra-dimensions-android icon indicating copy to clipboard operation
react-native-extra-dimensions-android copied to clipboard

Update RNPM for RN 0.60+

Open kidx5452 opened this issue 4 years ago • 17 comments

Project need add file react-native.config.js to update "rnpm" props in packages.json.

kidx5452 avatar Aug 15 '19 21:08 kidx5452

yeahh.. i am not being able to use this library because of RN 0.60+. Please update 'rnpm' props in packages.json

TheChanDI avatar Aug 30 '19 09:08 TheChanDI

@Sunhat would it be possible to release new version of the package to the npm?

janczizikow avatar Sep 18 '19 18:09 janczizikow

Any upcoming release ? Or we should use the master branch ?

andreifilip123 avatar Oct 24 '19 15:10 andreifilip123

Release?

iamandiradu avatar Nov 08 '19 14:11 iamandiradu

Release?

nathantaal avatar Nov 19 '19 12:11 nathantaal

Release?

christheyounger avatar Dec 30 '19 23:12 christheyounger

Can you please Release? 💪

a-tokyo avatar Feb 04 '20 02:02 a-tokyo

Dead project. Nobody should use this.

Sunhat avatar Mar 05 '20 20:03 Sunhat

@Sunhat any recommendations on alternatives?

rafalolszewski94 avatar Mar 11 '20 15:03 rafalolszewski94

@rafalolszewski94 have you found any alternatives?

ziyaddin avatar Aug 11 '20 13:08 ziyaddin

@ziyaddin I use this for now https://github.com/pluralcom/react-native-extra-dimensions-android

{
    "react-native-extra-dimensions-android": "https://github.com/pluralcom/react-native-extra-dimensions-android",
}

a-tokyo avatar Aug 11 '20 14:08 a-tokyo

If Airbnb do not need this, then I'm going to say nobody else does either

Sunhat avatar Aug 13 '20 07:08 Sunhat

Please provide me with an argument as to why this is necessary?

Sunhat avatar Aug 13 '20 07:08 Sunhat

Example usecase:

  if (Platform.OS === 'android') {
    const ExtraDimensions = require('react-native-extra-dimensions-android');
    const STATUSBAR_HEIGHT = ExtraDimensions.get('STATUS_BAR_HEIGHT');
    const WINDOW_HEIGHT =
      ExtraDimensions.get('REAL_WINDOW_HEIGHT') -
      STATUSBAR_HEIGHT -
      ExtraDimensions.get('SOFT_MENU_BAR_HEIGHT');
    return { STATUSBAR_HEIGHT, WINDOW_HEIGHT };
  }

NOTE: Different existing RN projects ALREADY use this repo, which means that upgrading RN would be an issue just because of RNPM issues that can be maintained.

a-tokyo avatar Aug 13 '20 11:08 a-tokyo

Yes, I fail to see why accepting a PR and creating a release tag is too big a burden. The package is otherwise functional, just needs an occasional update that others in the community can provide. You just need to create a tag.

christheyounger avatar Aug 15 '20 03:08 christheyounger

@ziyaddin I use this for now https://github.com/pluralcom/react-native-extra-dimensions-android

{
    "react-native-extra-dimensions-android": "https://github.com/pluralcom/react-native-extra-dimensions-android",
}

This is not working. Since in package.json has files defined and it does not have react-native.config.js in it. So npm does not fetch react-native.config.js file

rishabh876 avatar Oct 21 '21 07:10 rishabh876

If anyone is using https://github.com/pluralcom/react-native-extra-dimensions-android and would like us to publish an NPM release instead of just github, please let me know 👍🏻

NPM is more reliable since using github link simply refers to the latest version and not an exact version

a-tokyo avatar Oct 29 '21 01:10 a-tokyo