Iced-Latte icon indicating copy to clipboard operation
Iced-Latte copied to clipboard

GET product reviews request with an invalid value of param "size" the system returns all product reviews

Open TetianaPerinha opened this issue 1 year ago • 5 comments

Describe the bug When sending a GET product reviews request with an invalid value of param "size" the system returns all product reviews

To Reproduce Send the GET request as below use value for param size = %, +

curl --location '[https://iced-latte.uk/backend/api/v1/products/e6a4d7f2-d40e-4e5f-93b8-5d56ce6724c5/reviews?page={value}](https://iced-latte.uk/backend/api/v1/products/e6a4d7f2-d40e-4e5f-93b8-5d56ce6724c5/reviews?size={value}

Expected behavior The system should reject the request with 400 HTTP Status code "error": "Bad Request".

Actual result System accept the request and returns all product reviews. get all reviews with param size = % get all reviews with param size = +

TetianaPerinha avatar Jun 20 '24 18:06 TetianaPerinha

Hi @TetianaPerinha Please assign this bug to me and I will start working on this.

Prankurtiwari avatar Aug 08 '24 14:08 Prankurtiwari

Issue fixed in this PR. Please review

Prankurtiwari avatar Aug 24 '24 19:08 Prankurtiwari

Issue fixed in this PR. Please review

@Sunagatov Review please

TetianaPerinha avatar Aug 27 '24 02:08 TetianaPerinha

Issue fixed in this PR. Please review

@Sunagatov Review please

Can you please review and approve the PR for merge.

Prankurtiwari avatar Sep 07 '24 07:09 Prankurtiwari

@TetianaPerinha / @Sunagatov Any update guys on this PR. It been hanging there for more than two months. Do you have any review comment ?

Prankurtiwari avatar Oct 01 '24 19:10 Prankurtiwari