MPFlutterChart icon indicating copy to clipboard operation
MPFlutterChart copied to clipboard

null safety migration

Open tungtrinh opened this issue 4 years ago • 14 comments

Since flutter stable is already 2.0 which requires null safety, please help to migrate the plugin.

tungtrinh avatar Mar 09 '21 05:03 tungtrinh

Is anyone working on this?? I'd be willing to help!!

dgaedcke avatar May 19 '21 16:05 dgaedcke

This guy has done it, however he has removed many charts and examples, which is diverting from the actual repo https://github.com/greensopinion/MPFlutterChart

absar avatar May 23 '21 21:05 absar

Which one of forks is null safety and it is more consistent?

https://github.com/SunPointed/MPFlutterChart/network

There is no PieChartController, PieChartRenderer, PieDataSet, PieData, PieChart, ... in many of them

omidraha avatar Jun 04 '21 20:06 omidraha

hi @dgaedcke I think you started null safety, did you manage to complete it or opted for something else?

absar avatar Sep 01 '21 17:09 absar

Any update on this

ParvinderjitSF avatar Sep 24 '21 06:09 ParvinderjitSF

I did not finish my Null Safety conversion ... I was pulled onto another project but I plan to start looking at it again unless one of you has found a better solution ..

dgaedcke avatar Sep 27 '21 19:09 dgaedcke

I did not finish my Null Safety conversion ... I was pulled onto another project but I plan to start looking at it again unless one of you has found a better solution ..

Hi

I use your deposit, https://github.com/dgaedcke/MPFlutterChart when I use the stable Flutter Sdk 2.2.3 version, I have no problem

but when I upgraded to the new version flutter 2.5.2

Git error. Command: git clone --mirror [email protected]:greensopinion/OptimizedGestureDetector.git /Users/macbookpro/Flutter_Sdk/2.5.2/flutter/.pub-cache/git/cache/OptimizedGestureDetector-2cf40e1ea4df4731549ecaacffc0d6fa4740e388 stdout: stderr: Cloning into bare repository '/Users/macbookpro/Flutter_Sdk/2.5.2/flutter/.pub-cache/git/cache/OptimizedGestureDetector-2cf40e1ea4df4731549ecaacffc0d6fa4740e388'... ERROR: Repository not found. fatal: Could not read from remote repository.

Please make sure you have the correct access rights and the repository exists. exit code: 128

can u upgrade the repository with the new version Flutter sdk please ? thank you

Chakib-Temal avatar Oct 06 '21 09:10 Chakib-Temal

full version https://github.com/Juniorlpes/MPFlutterChart

m2faridi avatar Jan 22 '22 13:01 m2faridi

full version https://github.com/Juniorlpes/MPFlutterChart

you mean a full version null safety ?

Chakib-Temal avatar Jan 22 '22 13:01 Chakib-Temal

yes

m2faridi avatar Jan 22 '22 13:01 m2faridi

yes

did you fixed this errors ? erros to fix

Chakib-Temal avatar Jan 22 '22 13:01 Chakib-Temal

What problem does the error cause?

m2faridi avatar Jan 22 '22 13:01 m2faridi

What problem does the error cause?

take a look to my code (the value of high var can be null) i fix this because i had a nullPointerException on Multiple LineChart Or CombinedChart when i select (by click) a value from a chart

Highlight? high = widget.controller.painter!.getHighlightByTouchPoint(
        details.localPosition.dx,
        details.localPosition.dy,
      );
if (high != null) widget.controller.painter!.selectedValue(high);

the second one is a problem with a Zoom

Chakib-Temal avatar Jan 22 '22 14:01 Chakib-Temal

When will absar's pull request be merged?

balthier82 avatar Mar 27 '22 07:03 balthier82