SunBlack

Results 51 comments of SunBlack

I checked it short: Seems not. On MSVC CUDA is included via `/I"C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.7\include"` instead of `/external:I "C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.7\include"`, during the other dependencies are...

@jasjuang modernize-make-shared & modernize-make-unique will not have any effect, because we didn't had C++11 before ;).

I added two points for discussion.

> I think modernize-use-auto makes a lot of sense for iterators, but for new expressions and cast expressions to make sense, MinTypeNameLength has to be at least larger or equal...

I suggest to skip `modernize-use-default-member-init`, because I really don't like to have default values stored in header.

Just to mention: I don't believe we can integrate clang-tidy in near feature into build server. I tried it in our project, but there are some issues: - I have...

General question, due to: > Lack of time to review. Like I said, I'm not putting any priority in reviewing these PRs because they are time consuming and not in...

Well ok, don't know if I really have (currently) time to help on boost. There is a small thing I will change, if I have time (PCL is using boost...

Updated list, so progress is better to see.

I did run this night clang-tidy with all checks on our build server, to get a better feeling, which checks will produce smaller PRs and which bigger one. Well, this...