AES icon indicating copy to clipboard operation
AES copied to clipboard

Renaming classes

Open larshp opened this issue 9 years ago • 3 comments

Hi @Sumu-Ning, I would like to rename the classes so everything is prefixed with "ZCL_AES_", my suggestion:

rename ZCL_BYTE_PADDING_UTILITY to ZCL_AES_PADDING rename ZCL_PADDING_UTILITY_NONE to ZCL_AES_PADDING_NONE rename ZCL_PADDING_UTILITY_PKCS_5 to ZCL_AES_PADDING_PKCS_5 rename ZCL_PADDING_UTILITY_PKCS_7 to ZCL_AES_PADDING_PKCS_7

rename ZCL_RIJNDAEL_UTILITY to ZCL_AES_RIJNDAEL

larshp avatar Dec 04 '16 14:12 larshp

@Sumu-Ning any opinion on this?

larshp avatar Dec 13 '16 10:12 larshp

I am fine with them, except for the last one, which is more fundamental than aes.

If you have time , please make the change. I don't have abap environment any more :p

Sumu-Ning avatar Dec 14 '16 00:12 Sumu-Ning

Will do, just haven't had the time/focus to do it yet

larshp avatar Jan 05 '17 13:01 larshp