Changes to improve rds.py functionality.

[stevenchamales]

-splitting the single string with splitlines() causes problems with log entries that have multiple '\n' characters in them. SumoLogic already has internal heuristics that detect boundaries between log entries. Just allow this script to dump text to stdout, don't worry about trying to separate individual entries because SumoLogic does a good job of that without our help.

-had a few commas that needed to be removed.

-prepending the RDS instance name and the log filename to every line of text printed to stdout was also interfering with SumoLogic's internal log entry boundary detection heuristics. It's not necessary / useful for anything, so I removed it.

[stevenchamales]

Sounds good, thanks!

-Steve

Sent from my iPhone

On Jul 26, 2018, at 12:16 AM, Keith Koster [email protected] wrote:

@keithcodes commented on this pull request.

In Amazon_Web_Services/RDS/Log-Collection/rds.py:

@@ -29,7 +29,7 @@ #Get a list of the logs that have been modified since last run dbLogs=client.describe_db_log_files( DBInstanceIdentifier=dBInstanceIdentifier,

• FileLastWritten=lastReadDate, # Base this off of last query Hi Steve, thank you very much for your suggested improvements. We'll review your PR as soon as possible.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

[kb18951452]

@danreichert Would you mind reviewing this? I think your the most familiar with the code.

[wjakelee]

This project has not been worked on in almost 5 years, closing out