Nitrox icon indicating copy to clipboard operation
Nitrox copied to clipboard

Fix many building bugs

Open tornac1234 opened this issue 2 years ago • 2 comments

  • [x] Fix BasePieceSpawnProcessor when they are rerun
  • [x] Fix an issue where an object being built already has the NitroxId that is being added to it
  • [x] Investigate about geometry respawning causing NRE for Multiplayer cinematic components
  • [x] Change the way of identifying GameObjects
  • [x] Fix hatches not correctly building on alien containments
  • [x] Fix hatches not correctly building on MapRooms with something already built onto them
  • [x] Could be cool to investigate more about building that replaces stuff which is not counted as deleted (e.g building a corridor on a window) [FIXED]
  • ~~Repair an instance of ladders not being built on reconnection only~~

This may need more testing. Concerning the AreSameTechType() part, I've tested manually for all the pieces. Also I've made a messy reordering function in BasePieceSpawnPrioritizer.cs because I didn't know how to make it, can someone indicate me a better way of doing this please ? The ladders issue will remain since it can happen and not happen in the same conditions, I won't look more into it

tornac1234 avatar Jun 05 '22 18:06 tornac1234

There's a known issue about building hatches on a scanner room that is already connected to corridor

tornac1234 avatar Sep 07 '22 20:09 tornac1234

From the latest commit, we'll need to decide if we want to save some operations or not (may be more "dangerous")

tornac1234 avatar Sep 12 '22 18:09 tornac1234