Submitty icon indicating copy to clipboard operation
Submitty copied to clipboard

Superuser autograding status access

Open Adsalor opened this issue 1 year ago • 2 comments

Describe the bug A superuser logged into Submitty cannot view the 'Autograding status' page on the sidebar or directly access it via URL.

Expected behavior The superuser should be able to view/access the status page.

To Reproduce Steps to reproduce the behavior:

  1. Login to submitty as a superuser.
  2. Navigate to the page
    /autograding_status
  3. Despite being logged in as a superuser, you do not have access to this page

Configuration

  • OS: Windows 10
  • Browser: Edge, Firefox, Chrome

Screenshots Instructors can access this page: instructor_autograding_status But superusers cannot view it in their sidebar: superuser_no_status And attempting to access it lands on the 'you do not have access' page: superuser_no_access

Adsalor avatar Sep 06 '24 02:09 Adsalor

I can work on this.

Looks like the issue might be coming from $is_instructor, as superusers aren't mentioned to have access to autograding status in GlobalController.php and the access is instead explicitly given to instructors. Looking at AutogradingStatusController.php, the site access is also only explicitly checking for instructors, not superusers as well.

Are superusers not supposed to be granted instructor privileges?

@williamschen23

Hawaiian-Pizza avatar Sep 09 '24 21:09 Hawaiian-Pizza

Hi @Hawaiian-Pizza,

Thank you for your interest in the Submitty open source project!

We encourage you to join our Zulip server to discuss new features requests, bug reports, and technical implementation questions.

We welcome contributions from new developers! Please read our documentation on how to get started with Submitty, specifically our pages on setting up your development environment and making a pull request.

NOTE: We do not use the Github issue 'assign' feature for first time prospective contributors. You do not need to be assigned to an issue to create a pull request that will be reviewed by our team and then merged if it appropriately resolves the issue.

github-actions[bot] avatar Sep 09 '24 21:09 github-actions[bot]

@yanliw123 This issue can be closed since, this has been solved.

mrtechtroid avatar Feb 15 '25 04:02 mrtechtroid

Hi @mrtechtroid,

Thank you for your interest in the Submitty open source project!

We encourage you to join our Zulip server to discuss new features requests, bug reports, and technical implementation questions.

We welcome contributions from new developers! Please read our documentation on how to get started with Submitty, specifically our pages on setting up your development environment and making a pull request.

NOTE: We do not use the Github issue 'assign' feature for first time prospective contributors. You do not need to be assigned to an issue to create a pull request that will be reviewed by our team and then merged if it appropriately resolves the issue.

github-actions[bot] avatar Feb 15 '25 04:02 github-actions[bot]